services: add notice of broken feature #22942
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Waiting for healthy dependencies is not supported in version 3 of docker compose, as explained in: https://docs.docker.com/compose/releases/release-notes/#1100 The `version` key is also ignored now, so this whole feature is actually broken. I think at the very least, this should be mentioned in the documentation. This took me 2 days of debugging to figure out, and a notice here would've saved me a lot of time.
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
github-actions
bot
added
the
area/compose
Contributor
|
Hi @sillydan1, the docs site shows the current version of the compose file reference which is the Compose Specification, which is the latest and recommended version. Your fix is not applicable in this case. For more info on the Compose Spec and how it relates to compose file v3, see this page https://docs.docker.com/compose/intro/history/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Waiting for healthy dependencies is not supported in version 3 of docker compose, as explained in:
https://docs.docker.com/compose/releases/release-notes/#1100
The
versionkey is also ignored now, so this whole feature is actually broken. I think at the very least, this should be mentioned in the documentation.This took me 2 days of debugging to figure out, and a notice here would've saved me a lot of time.
Related issues or tickets
Reviews